Merged
Conversation
ahesford
reviewed
Dec 7, 2025
srcpkgs/kmscon/template
Outdated
| depends="xkeyboard-config" | ||
| short_desc="Terminal emulator based on Kernel Mode Setting (KMS)" | ||
| maintainer="Orphaned <orphan@voidlinux.org>" | ||
| maintainer="Huang FTS427 <FTS427@outlook.com>" |
Member
There was a problem hiding this comment.
Please remove the adoption. We would like to see maintainers establish a history of good stewardship before putting their names on packages.
FTS427
changed the title
Member
|
Please squash these commits down to one for |
FTS427
force-pushed
the
kmscon_9.2.0_update
branch
from
747a416 to
86a6055
Compare
ahesford
requested changes
Jan 1, 2026
srcpkgs/kmscon/template
Outdated
| depends="xkeyboard-config" | ||
| short_desc="Terminal emulator based on Kernel Mode Setting (KMS)" | ||
| maintainer="Orphaned <orphan@voidlinux.org>" | ||
| maintainer="Huang FTS427 <FTS427@outlook.com>" |
Member
There was a problem hiding this comment.
This change was supposed to be dropped.
srcpkgs/libtsm/template
Outdated
|
|
||
| libtsm-devel_package() { | ||
| depends="${sourcepkg}>=${version}_${revision}" | ||
| depends="${makedepends} libtsm>=${version}_${revision}" |
Member
There was a problem hiding this comment.
Use ${sourcepkg} rather than libtsm as in the original.
Are both makedepends actually required by programs that link against this library? In particular, are they mentioned in a pkg-config descriptor included with this package?
FTS427
force-pushed
the
kmscon_9.2.0_update
branch
from
86a6055 to
f2c77c4
Compare
Member
|
It seems you've folded most of the tsm update into the ksmcon commit. |
FTS427
force-pushed
the
kmscon_9.2.0_update
branch
from
f2c77c4 to
c6261e0
Compare
Member
|
This still comingles the |
FTS427
changed the title
Duncaen
force-pushed
the
kmscon_9.2.0_update
branch
from
7a4303c to
79792c3
Compare
Duncaen
force-pushed
the
kmscon_9.2.0_update
branch
from
79792c3 to
1996f8c
Compare
Co-authored-by: Duncaen <duncaen@voidlinux.org>
Duncaen
force-pushed
the
kmscon_9.2.0_update
branch
from
1996f8c to
8ec6f69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing