Skip to content

fix: resolve scss styles#346

Closed
KaelWD wants to merge 1 commit intomasterfrom
fix/resolve-scss
Closed

fix: resolve scss styles#346
KaelWD wants to merge 1 commit intomasterfrom
fix/resolve-scss

Conversation

@KaelWD
Copy link
Member

@KaelWD KaelWD commented Apr 2, 2025

Alternate approach to #345 with resolve() instead of fs.exists()

@userquin
Copy link
Member

userquin commented Apr 2, 2025

IIRC this approach will not work since the error is in the Vite transform (css) hook not in the resolveId, we need the sccs resolved here and so the transform in the pipeline won't fail

@KaelWD
Copy link
Member Author

KaelWD commented Apr 2, 2025

Not sure what you mean, this tries to resolve .sass then .scss if that fails

@KaelWD
Copy link
Member Author

KaelWD commented Apr 3, 2025

Calling resolve in webpack is practically impossible, it would have to use fs anyway so might as well keep it the same for both.

@KaelWD KaelWD closed this Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants