xml: T8271: cleanup duplicate includes and split duplicate code into new building blocks#4991
Merged
c-po merged 6 commits intovyos:currentfrom Feb 16, 2026
Merged
xml: T8271: cleanup duplicate includes and split duplicate code into new building blocks#4991c-po merged 6 commits intovyos:currentfrom
c-po merged 6 commits intovyos:currentfrom
Conversation
During development and XML node refactoring the resulting node.def files are rebuild over and over again. Unfortunately they are not cleaned up during subsequent calls to "make interface_definitions" or "make op_mode_definitions". This could cause previous build node.def files to still exist after a rebuild which adds potential false-positives during refactoring.
Verified that the resulting node.def files are still the same by: $ make interface_definitions $ git add -f templates-cfg $ ... refactor $ make interface_definitions $ git diff templates-cfg No change in any node.def file detected.
$ make interface_definitions $ git add -f templates-cfg $ ... refactor $ make interface_definitions $ git diff templates-cfg No change in any node.def file detected.
…equivalent $ make interface_definitions $ git add -f templates-cfg $ ... refactor $ make interface_definitions $ git diff templates-cfg No change in any node.def file detected.
|
👍 |
12 tasks
|
CI integration 👍 passed! Details
|
sarthurdev
approved these changes
Feb 15, 2026
Member
sarthurdev
left a comment
sarthurdev
left a comment
There was a problem hiding this comment.
Cleanup XML, trust Christian's testing. Smoketests pass.
jestabro
approved these changes
Feb 16, 2026
Contributor
jestabro
left a comment
jestabro
left a comment
There was a problem hiding this comment.
This was smartly tested for changes in generated node.def files. All looks good.
vyosbot
added
mirror-initiated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change summary
After every XML refactoring the generated
node.deffiles got evaluated by:So that no change in any
node.deffile detected - ecept the one which changes the CLI completion helper strings.Types of changes
Related Task(s)
Checklist: