[css-mixins-1] Fix space placement in serialize a CSSFunctionRule#13605
Merged
[css-mixins-1] Fix space placement in serialize a CSSFunctionRule#13605
Conversation
By moving the space from step 5 to the start of step 6 we ensure that
there is a space before the '{' regardless of whether we serialize the
return type (i.e. "--foo() {..." rather than "--foo(){...")
By moving the space from after the '{' in step 6 to before the first
serialized rule in step 7 we ensure that there is only one space (the
one in step 8) between the '{' and '}' in the case that there are no
rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By moving the space from step 5 to the start of step 6 we ensure that there is a space before the '{' regardless of whether we serialize the return type (i.e. "--foo() {..." rather than "--foo(){...")
By moving the space from after the '{' in step 6 to before the first serialized rule in step 7 we ensure that there is only one space (the one in step 8) between the '{' and '}' in the case that there are no rules.
Both of these changes are expected in WPT