[css-conditional-5] Extend CSSContainerRule for multiple conditions.#13635
Open
[css-conditional-5] Extend CSSContainerRule for multiple conditions.#13635
Conversation
Collaborator
Author
|
@tabatkins any strong opinions on the "String or array" thing? I think that probably just returning the empty string when there are multiple conditions is better, because otherwise things like |
emilio
force-pushed
the
condition-rule-cssom
branch
from
24674cd to
a962648
Compare
Contributor
|
I don't have any strong feelings on the shape of this, I'd be fine with either approach. |
Collaborator
Author
|
https://phabricator.services.mozilla.com/D287344 has some implementation and tests of this proposal. |
Member
|
I do weakly prefer returning the empty string when it's multiple conditions, yeah. |
Collaborator
Author
|
@mirisuzanne could I get your stamp as editor for the spec text? |
lando-prod-mozilla bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Mar 26, 2026
…ebidl,smaug As per w3c/csswg-drafts#13635. To be landed once there's a resolution and so on. The multiple conditions subtest is expected to fail until we implement parsing for those. Differential Revision: https://phabricator.services.mozilla.com/D287344
moz-wptsync-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 26, 2026
As per w3c/csswg-drafts#13635. To be landed once there's a resolution and so on. The multiple conditions subtest is expected to fail until we implement parsing for those. Differential Revision: https://phabricator.services.mozilla.com/D287344 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2022827 gecko-commit: 89c6e5274681ec27ca9ba117b32c38a89ce5362f gecko-commit-git: ede0eccbeb8afa2dbd04e1876fbe6115432eadd1 gecko-reviewers: AlaskanEmily, webidl, smaug
moz-wptsync-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 26, 2026
As per w3c/csswg-drafts#13635. To be landed once there's a resolution and so on. The multiple conditions subtest is expected to fail until we implement parsing for those. Differential Revision: https://phabricator.services.mozilla.com/D287344 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2022827 gecko-commit: 89c6e5274681ec27ca9ba117b32c38a89ce5362f gecko-commit-git: ede0eccbeb8afa2dbd04e1876fbe6115432eadd1 gecko-reviewers: AlaskanEmily, webidl, smaug
AtkinsSJ
reviewed
Mar 26, 2026
AtkinsSJ
reviewed
Mar 26, 2026
AtkinsSJ
reviewed
Mar 26, 2026
AtkinsSJ
reviewed
Mar 26, 2026
Return an empty string for multiple conditions as per resolution. Fixes #10845
emilio
force-pushed
the
condition-rule-cssom
branch
from
a962648 to
4e66daf
Compare
Collaborator
Author
|
@AtkinsSJ thanks for the review! I think I addressed your comments, but lmk otherwise :) |
mirisuzanne
approved these changes
Mar 26, 2026
Contributor
mirisuzanne
left a comment
mirisuzanne
left a comment
There was a problem hiding this comment.
This looks good to me (with the caveat that I have very little experience with CSSOM from either the spec or author end)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open questions:
Do we want to do this "return string or array thing"? Or should we just return the empty string on
containerName/containerQuerywhen there are multiple conditions? Maybe that's simpler.If we do the "string or array thing", do we still want to expose the "always array" version (
containerNames/containerQueries)? I think so, but I guess I could go either way.Fixes #10845