-
Notifications
You must be signed in to change notification settings - Fork 73
emulation.setMediaFeaturesOverride
#1076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sadym-chromium
wants to merge
47
commits into
main
Choose a base branch
from
sadym/emulation.setMediaFeaturesOverride
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+161
−1
Open
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
49c74f3
stored configuration
sadym-chromium f37f1ee
`emulation.setScrollbarTypeOverride`
sadym-chromium 81ffe34
rename
sadym-chromium 801a1bd
move setting to remote end
sadym-chromium 43108d9
remove deprecated endpoint
sadym-chromium 2b43d31
update scrollbar type override on new navigable
sadym-chromium df3cab1
Update index.bs
sadym-chromium 3d59948
remote end configuration
sadym-chromium 2aa7e4b
add a note
sadym-chromium b5d97cf
"stored remote end configuration"
sadym-chromium 6301b81
"[=remote end configuration=]"
sadym-chromium 8fbb426
docs: Clarify that scrollbar type override is applied for a specific …
sadym-chromium 694e64b
`store remote end config`
sadym-chromium 92b9183
whitespace
sadym-chromium 97b36c3
`emulation.setMediaFeaturesOverride`
sadym-chromium 27f8016
update types
sadym-chromium 13da3aa
fixes
sadym-chromium 2baf4d5
refactor
sadym-chromium 3c71c7b
rename
sadym-chromium 8b902f1
format
sadym-chromium efd4fdd
Update index.bs
sadym-chromium ecf7cbf
WebDriver configuration/unset
sadym-chromium 0fb4a75
WebDriver configuration/store
sadym-chromium fe4e633
assert
sadym-chromium 55325be
comment
sadym-chromium 7a75b6d
note
sadym-chromium c373238
fix
sadym-chromium abb4e1a
fix
sadym-chromium 45bb310
reorder
sadym-chromium 6da5727
assert
sadym-chromium 80f80bd
classic" / "overlay"
sadym-chromium 555180b
fixes
sadym-chromium e10e4eb
omitted
sadym-chromium c6511ae
WebDriver configuration scoped to remote end
sadym-chromium 03ab6df
remove export
sadym-chromium 42ef86d
Revert "WebDriver configuration scoped to remote end"
sadym-chromium a2eba0f
updat
sadym-chromium 4cb48eb
Merge branch 'main' into sadym/scrollbar-3
sadym-chromium 6d0c419
Merge branch 'sadym/scrollbar-3' into sadym/emulation.setMediaFeature…
sadym-chromium 21a5a68
Merge branch 'main' into sadym/emulation.setMediaFeaturesOverride
sadym-chromium a2a4053
fix merge
sadym-chromium fa4e3da
add css patch
sadym-chromium bdb0af4
fix build
sadym-chromium a4cba20
allow for setting and cleaning meadia features one-by-one.
sadym-chromium 06de83e
Update index.bs
sadym-chromium 312ce41
extend with https://drafts.csswg.org/mediaqueries-5/#valdef-media-poi…
sadym-chromium 3a1ec08
"nav-controls": "none"
sadym-chromium File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not a fan of this API as it requires changing WebDriver BiDi spec whenever there is a new media feature available in the underlying browser.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since media query features generally support unknown values, e.g., in CSS rules or in the matchMedia API, I think it might be beneficial to just pass a list of media features to the browser without re-listing all possible feature names in the WebDriver BiDi's CDDL. WDYT @jgraham ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lutien WDYT about this proposal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we can ensure interoperability between the browsers if we don't specify the supported media features here, and we have to write wpt tests anyway for every feature.