Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
queryish is a library I created for wrapping arbitrary datasources with an API that's consistent with Django's queryset - originally so that we could have choosers in Wagtail that pick objects from a REST API instead of the local database. This of course is a good fit for django-modelsearch's BaseSearchResults class.
Refactoring BaseSearchResults on top of Queryish allows us to eliminate a chunk of code, benefit from Queryish's wider unit testing for features like slicing and result caching, and potentially support a larger subset of the Queryset API (
.first()is a quick win that works now; with more work it could be possible to support chaining things like.filterand.getafter thesearchclause).