Fix 500 error when searching for words containing apostrophes#76
Open
Adithya00012 wants to merge 1 commit intowagtail:mainfrom
Open
Fix 500 error when searching for words containing apostrophes#76Adithya00012 wants to merge 1 commit intowagtail:mainfrom
Adithya00012 wants to merge 1 commit intowagtail:mainfrom
Conversation
…ticsearch admin search
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes wagtail/wagtail#13956
Description
When searching for words containing apostrophes (e.g.
it's) in the Wagtailadmin sidebar search with Elasticsearch, a 500 error was raised with
NotImplementedError: 'And' is not supported for autocomplete queries.parse_query_stringwas splitting on all apostrophes, treatingit'sasAnd(PlainText('it'), Phrase('s')). The Elasticsearch autocomplete backenddoes not support
Andqueries.The fix updates
parse_query_stringto only split on apostrophes that areNOT inside a word, using regex lookahead and lookbehind. Mid-word apostrophes
like
it'sare now treated as plain text.