Enforce additional clippy lints

[ricochet]

Enforce additional clippy lints in Cargo.toml and have crates inherit.

[lints.clippy]
# Correctness & Safety
unwrap_used = "warn"          # Prefer expect() or proper error handling
expect_used = "warn"          # Even stricter - force Result handling
panic = "warn"                # No panics in library code
indexing_slicing = "warn"     # Use .get() instead of [i]

# Performance
inefficient_to_string = "warn"
needless_collect = "warn"
needless_pass_by_value = "warn"
trivially_copy_pass_by_ref = "warn"
unnecessary_box_returns = "warn"

# Code Quality
clone_on_ref_ptr = "warn"     # Explicit Arc::clone() over .clone()
dbg_macro = "warn"            # No dbg! in production
print_stdout = "warn"         # No println! in libraries
todo = "warn"                 # No TODO in production

cargo clippy -- -W clippy::pedantic 2>&1 | grep -o -i warning | wc -l came in at 735. So I do not recommend starting there.

[ricochet]

After #246, the remaining ones require more changes or are more iffy if we even want these:

1. needless_pass_by_value - flagged idiomatic impl ToString patterns in
   CommandOutput::ok() and CommandOutput::error()
2. todo - there's a todo!("use common dir") in crates/wash/src/wit.rs:180 that needs
   actual implementation
3. clone_on_ref_ptr - many violations, requires changing arc.clone() → Arc::clone(&arc)
   throughout

[if0ne]

Hey. It might also be worth adding #[forbid(unsafe_code)]

[ricochet]

Closing this tracking issue now that the lints we want in have landed.