Skip to content

Fix Helm chart to respect nats.enabled flag#182

Merged
lxfontes merged 2 commits intowasmCloud:mainfrom
casualjim:copilot/fix-nats-deployment-issue
Dec 1, 2025
Merged

Fix Helm chart to respect nats.enabled flag#182
lxfontes merged 2 commits intowasmCloud:mainfrom
casualjim:copilot/fix-nats-deployment-issue

Conversation

@casualjim
Copy link
Contributor

@casualjim casualjim commented Dec 1, 2025

I have my own nats cluster and I tried to disable nats in the chart but it would still deploy a nats cluster.

These changes were made by copilot so I understand if you don't want that.

NATS resources (Deployment, Service, ServiceAccount) were deployed regardless of the nats.enabled setting in values.yaml.

Changes

  • Wrap templates/nats/deployment.yaml with {{- if .Values.nats.enabled }}
  • Wrap templates/nats/service.yaml with {{- if .Values.nats.enabled }}
  • Update templates/nats/serviceaccount.yaml condition to check both nats.enabled and serviceAccount.create

Verification

# With nats.enabled=false, no NATS resources rendered
helm template test . --set nats.enabled=false | grep "name: nats"
# (empty output)

# Default behavior unchanged
helm template test . | grep "name: nats"
# name: nats (deployment, service, serviceaccount all present)

Copilot AI and others added 2 commits November 30, 2025 18:55
Co-authored-by: casualjim <456109+casualjim@users.noreply.github.com>
@casualjim casualjim requested a review from a team as a code owner December 1, 2025 05:32
Copy link
Member

@lxfontes lxfontes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@lxfontes lxfontes added this pull request to the merge queue Dec 1, 2025
Merged via the queue into wasmCloud:main with commit 5301182 Dec 1, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants