Fix Helm chart to respect nats.enabled flag#182
Merged
lxfontes merged 2 commits intowasmCloud:mainfrom Dec 1, 2025
Merged
Conversation
Co-authored-by: casualjim <456109+casualjim@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have my own nats cluster and I tried to disable nats in the chart but it would still deploy a nats cluster.
These changes were made by copilot so I understand if you don't want that.
NATS resources (Deployment, Service, ServiceAccount) were deployed regardless of the
nats.enabledsetting in values.yaml.Changes
templates/nats/deployment.yamlwith{{- if .Values.nats.enabled }}templates/nats/service.yamlwith{{- if .Values.nats.enabled }}templates/nats/serviceaccount.yamlcondition to check bothnats.enabledandserviceAccount.createVerification