fix: prevent cargo cache invalidation in wash-runtime build script#220
Merged
lxfontes merged 1 commit intowasmCloud:mainfrom Jan 5, 2026
Merged
Conversation
Signed-off-by: Aditya <aditya.salunkh919@gmail.com>
dman-os
approved these changes
Jan 4, 2026
Contributor
dman-os
left a comment
dman-os
left a comment
There was a problem hiding this comment.
Thanks, you didn't have to jump on this immediately on a Sun :)
Contributor
Author
No problem at all! Was already online and it only took a few minutes to sort out. |
lxfontes
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or Problem
The build script was watching entire example directories and the fixtures
directory with
cargo:rerun-if-changed, which included their target/subdirectories.
Because the build script itself builds into those target/
directories, this was creating a circular dependency that was invalidating cargo's
cache on every build, causing a rerun everytime.
Changed to watch only the source inputs that should trigger rebuilds:
This will prevent the build script from triggering itself when it writes
build artifacts, fixing the cache-busting issue.
Related Issues
#121
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification