Merged
Conversation
We have one test that does a lot of heavy lifting. I considered deleting and starting over, but instead opted to clean it up and make it more maintainable. crates/wash-runtime/tests/integration_http_counter.rs: - Removed ~100 lines of ASCII art/decorative println! output across 3 test functions - Removed 35 lines of commented-out test code (restricted outbound access test with TODO) - Extracted 3 shared helper functions (http_counter_host_interfaces, start_host_with_all_plugins, http_counter_workload_request) to eliminate copy-paste setup across all 3 tests crates/wash-runtime/src/plugin/wasi_blobstore/in_memory.rs - Replaced 5 trivial struct-field tests with 4 behavioral tests crates/wash-runtime/src/plugin/wasi_keyvalue/in_memory.rs - Replaced 4 trivial tests with 3 behavioral tests For oci.rs, removed tests that only tested HashMap/BTreeMap insertion crates/wash/src/cli/wit.rs - Fixed 2 tests to call actual code Signed-off-by: Bailey Hayes <bailey@cosmonic.com>
lxfontes
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have one test that does a lot of heavy lifting.
I considered deleting and starting over, but instead opted to
clean it up and make it more maintainable.
crates/wash-runtime/tests/integration_http_counter.rs:
http_counter_workload_request) to eliminate copy-paste setup across all 3 tests
crates/wash-runtime/src/plugin/wasi_blobstore/in_memory.rs
crates/wash-runtime/src/plugin/wasi_keyvalue/in_memory.rs
For oci.rs, removed tests that only tested HashMap/BTreeMap insertion
crates/wash/src/cli/wit.rs - Fixed 2 tests to call actual code