stdout still produces a file

[uncomfyhalomacro]

How to reproduce

Assuming you are in $HOME and swappy installed:

wayshot - | swappy -f - -o somefilepath.png

This saves a regular file while also passing the data as stdout to swappy. See video for behaviour.

wayshot-stdout-bug.mp4

[uncomfyhalomacro]

I believe the culprit is in these lines

wayshot/wayshot/src/wayshot.rs

Lines 165 to 174 in 28331dc

	if let Some(f) = file {
	image_buffer.save(f)?;
	}
	if stdout_print {
	let mut buffer = Cursor::new(Vec::new());
	image_buffer.write_to(&mut buffer, encoding.into())?;
	writer.write_all(buffer.get_ref())?;
	image_buf = Some(buffer);
	}

[Gigas002]

This was made by design, why change again?
The point was to make this behavior more configurable and less conflicting.

change: stdout, clipboard and FILE doesn't conflict with each other anymore. Screenshot file will not appear on disk now only if no FILE provided via args and file in config.toml is false at the same time. In all other cases file is saved, with path following this priority: FILE > config.file.path > current directory. Not breaking, but two category of users affected. First, users currently using - as FILE will notice that aside from stdout, there's a screenshot file in current directory (if no config edits were made). Second catogory is users, that did not provide FILE but provided --clipboard argument: these users will see similar behavior as above

See: #154

[Decodetalkers]

This was made by design, why change again?
The point was to make this behavior more configurable and less conflicting.

change: stdout, clipboard and FILE doesn't conflict with each other anymore. Screenshot file will not appear on disk now only if no FILE provided via args and file in config.toml is false at the same time. In all other cases file is saved, with path following this priority: FILE > config.file.path > current directory. Not breaking, but two category of users affected. First, users currently using - as FILE will notice that aside from stdout, there's a screenshot file in current directory (if no config edits were made). Second catogory is users, that did not provide FILE but provided --clipboard argument: these users will see similar behavior as above

See: #154

I see, can you help revert the change back? Thanks

[Gigas002]

Not rn (not at PC atm), but yeah, sure. Mostly need to check if it builds and if clippy's happy about the changes