You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR introduces support for encoding jpeg-xl, closes#11.
Since there's no yet support for jxl in image-rs current version temporary uses jpegxl-rs crate.
Note, that since there's no rust-native jxl encoder, this crate adds dependency for libjxl. I think we may need to make this [feature] flag instead?
Also, there are some options available for controlling jxl encoder, such as lossless, quality, speed. We can make it configurable via config.toml file, though do we really need to go that far? Right now encoder uses default settings, which creates visualy lossless results.
One more thing to note, that this PR only adds ability for creating screenshot file as jxl, for now, at least. The clipboard and stdout result will be a simple jpeg. I am not sure if we should change this behavior, actually.
@EwoutH
It's usable in its current state, except for clipboard screenshot.
I'm not sure it should be merged rn with this dirty workaround, but at the same time jxl support in image-rs isn't moving at all.
For now, you can use this pr as patch file and build from master branch, with this patch applied, if you want to use this feature.
Sorry it took a while for me to return to this PR, but I think it should work in all scenarios now.
Unfortunately, jxl-rs only have decoding support, so it doesn't make much sense to use it in our cases, so we have to depend on native libjxl installed on user's machines for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces support for encoding jpeg-xl, closes #11.
Since there's no yet support for
jxlinimage-rscurrent version temporary uses jpegxl-rs crate.Note, that since there's no rust-native
jxlencoder, this crate adds dependency forlibjxl. I think we may need to make this[feature]flag instead?Also, there are some options available for controlling
jxlencoder, such aslossless,quality,speed. We can make it configurable viaconfig.tomlfile, though do we really need to go that far? Right now encoder uses default settings, which createsvisualy losslessresults.One more thing to note, that this PR only adds ability for creating screenshot file as
jxl, for now, at least. Theclipboardandstdoutresult will be a simplejpeg. I am not sure if we should change this behavior, actually.