Fix scaling detection for portrait displays#256
Merged
Shinyzenith merged 1 commit intowaycrate:mainfrom Dec 27, 2025
Merged
Conversation
Shinyzenith
approved these changes
Dec 27, 2025
Member
|
Thanks for the detailed fix! ❤️👏 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #256 +/- ##
==========================================
- Coverage 19.63% 19.63% -0.01%
==========================================
Files 13 13
Lines 2704 2705 +1
==========================================
Hits 531 531
- Misses 2173 2174 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed calculating the needed resize for portrait displays. The
Sizestruct passed toimage_util::rotate_image_bufferwas at some moment changed to include the transformation already but wasn't changed there.Tested using the following setup:
JPG used below as PNGs were too big to upload here.
With 1.0 scale on the right portrait
Before
After
With 1.25 scale on the right portrait
Before
After