Skip to content

tidy up apis, mainly the part of egl and waymirror#270

Merged
Decodetalkers merged 25 commits intowaycrate:mainfrom
Decodetalkers:egl
Jan 20, 2026
Merged

tidy up apis, mainly the part of egl and waymirror#270
Decodetalkers merged 25 commits intowaycrate:mainfrom
Decodetalkers:egl

Conversation

@Decodetalkers
Copy link
Collaborator

@Decodetalkers Decodetalkers commented Jan 15, 2026

And use the egl library forked by us

  • use the egl library forked by us. because the origin one is not at good maintenance.
  • tidy up the waymirror project.
  • tidy up the api, make the params follow a good order
  • add easy to use egl screencast api

@Decodetalkers Decodetalkers marked this pull request as draft January 15, 2026 14:35
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2026

Codecov Report

❌ Patch coverage is 0.82988% with 239 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.53%. Comparing base (5fcdd11) to head (90c3817).

Files with missing lines Patch % Lines
waymirror-egl/src/state.rs 0.00% 89 Missing ⚠️
libwayshot/src/screencast.rs 0.00% 66 Missing ⚠️
libwayshot/src/lib.rs 0.00% 44 Missing ⚠️
waymirror-egl/src/main.rs 0.00% 22 Missing ⚠️
waymirror-egl/src/dispatch.rs 0.00% 17 Missing ⚠️
libwayshot/src/screencopy.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #270      +/-   ##
==========================================
- Coverage   18.85%   16.53%   -2.32%     
==========================================
  Files          13       17       +4     
  Lines        2816     3211     +395     
==========================================
  Hits          531      531              
- Misses       2285     2680     +395     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Decodetalkers
Copy link
Collaborator Author

The color is wired. and there are unhandled error in that original egl lib.

Since egl will only be used in screencast, so can we delete the screenshot api in lib.rs?

@Decodetalkers Decodetalkers requested review from Gigas002 and Shinyzenith and removed request for Gigas002 January 16, 2026 09:40
@Decodetalkers Decodetalkers marked this pull request as ready for review January 17, 2026 04:08
we should not invoke get_error ourself
@Shinyzenith
Copy link
Member

Interesting pr, but don't we have a egl backend already? Am I mistaken?

do not init display for many times

adjust the order of params
need follow the order, first target, then options.
Because cursor is always needed, it should be followed later. Finally is
optional Region
@Decodetalkers
Copy link
Collaborator Author

Interesting pr, but don't we have a egl backend already? Am I mistaken?

Emm. the name of pr is wrong.. I just tidy up the relative api, and use the project that we forked. And then now I tidied up more things..

so mainly , I tidied up the egl api, and tidy up the waymirror, add a screencast api for libwayshot

@Decodetalkers Decodetalkers changed the title Egl tidy up apis, many the part of egl Jan 17, 2026
@Decodetalkers Decodetalkers changed the title tidy up apis, many the part of egl tidy up apis, mainly the part of egl Jan 17, 2026
@Decodetalkers Decodetalkers changed the title tidy up apis, mainly the part of egl tidy up apis, mainly the part of egl and waymirror Jan 17, 2026
@Decodetalkers
Copy link
Collaborator Author

Now the only problem is

file descriptor expected, object (32), message keymap(uhu)ress <ESC> to quit.
Io error: Invalid argument (os error 22)
Error: Backend(Io(Os { code: 22, kind: InvalidInput, message: "Invalid argument" }))

Seems the fd leaks.. I do not know why

@Decodetalkers
Copy link
Collaborator Author

Decodetalkers commented Jan 20, 2026

Ok, I will take responsible for this pr. I will merge it, @Gigas002 thank you for review it

@Decodetalkers Decodetalkers merged commit aeba9c3 into waycrate:main Jan 20, 2026
6 checks passed
@Gigas002
Copy link
Collaborator

@Decodetalkers thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants