tidy up apis, mainly the part of egl and waymirror#270
tidy up apis, mainly the part of egl and waymirror#270Decodetalkers merged 25 commits intowaycrate:mainfrom
Conversation
some tidy up
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #270 +/- ##
==========================================
- Coverage 18.85% 16.53% -2.32%
==========================================
Files 13 17 +4
Lines 2816 3211 +395
==========================================
Hits 531 531
- Misses 2285 2680 +395 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The color is wired. and there are unhandled error in that original egl lib. Since egl will only be used in screencast, so can we delete the screenshot api in lib.rs? |
since we are just using the static api, so it is needless. We need to use pkgconfig to find it first and then use it. There is no way on linux platform , using wayland, but use the egl lower than 1.5
we should not invoke get_error ourself
|
Interesting pr, but don't we have a egl backend already? Am I mistaken? |
do not init display for many times adjust the order of params
need follow the order, first target, then options. Because cursor is always needed, it should be followed later. Finally is optional Region
Emm. the name of pr is wrong.. I just tidy up the relative api, and use the project that we forked. And then now I tidied up more things.. so mainly , I tidied up the egl api, and tidy up the waymirror, add a screencast api for libwayshot |
|
Now the only problem is Seems the fd leaks.. I do not know why |
|
Ok, I will take responsible for this pr. I will merge it, @Gigas002 thank you for review it |
|
@Decodetalkers thanks! |
And use the egl library forked by us