Skip to content

refactor: refactor CI by separating on several files#315

Merged
Gigas002 merged 1 commit intowaycrate:mainfrom
Gigas002:refactor/ci-overhaul
Mar 18, 2026
Merged

refactor: refactor CI by separating on several files#315
Gigas002 merged 1 commit intowaycrate:mainfrom
Gigas002:refactor/ci-overhaul

Conversation

@Gigas002
Copy link
Collaborator

Mostly moving stuff around, but minor changes included:

  • build three patterns: all-features, default-features, minimal (with just png feature)
  • separate coverage reports for libwayshot and wayshot

Also, left unchanged, but in #234 @Shinyzenith mentioned that probably we don't need to distribute binaries with release, maybe we should remove this part of job? If not, we should probably add all-features to it? Or distribute several flavors? Or just the default? I'm not sure what'd be best here.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.84%. Comparing base (3c97770) to head (34bafe1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #315      +/-   ##
==========================================
+ Coverage   16.01%   17.84%   +1.82%     
==========================================
  Files          23       19       -4     
  Lines        3291     2954     -337     
==========================================
  Hits          527      527              
+ Misses       2764     2427     -337     
Flag Coverage Δ
libwayshot 22.19% <ø> (?)
wayshot 0.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Gigas002 Gigas002 marked this pull request as ready for review March 18, 2026 09:25
@Gigas002 Gigas002 requested a review from Decodetalkers March 18, 2026 09:25
@Gigas002 Gigas002 self-assigned this Mar 18, 2026
@Gigas002 Gigas002 added the github_actions Pull requests that update GitHub Actions code label Mar 18, 2026
Copy link
Collaborator

@Decodetalkers Decodetalkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good for me! I have thought this ci is too long long ago

@Gigas002 Gigas002 merged commit b89c80c into waycrate:main Mar 18, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Development

Successfully merging this pull request may close these issues.

3 participants