Migrate from npm to yarn v2 #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Noting that the pr check workflow will need to be upgraded to reflect the yarn changes as well. |
Collaborator
|
seems like yarn is not appreciated for something like |
Collaborator
Author
ah, looks like worker_threads aren't supported before node 10.5. I believe this PR should unblock mine. 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Migrates the package manager from npm to yarn v2.
Relates to #34.
Types of changes
Put an
xin the boxes that applyTest Plan and Documentation
Unit tests are passing.
No logic changes are included in this PR.
Further comments
I decided to migrate to yarn2 instead of yarn1 after reading their docs: https://yarnpkg.com/getting-started/qa#why-should-you-upgrade-to-yarn-modern