Conversation
ddpbsd
added a commit
to ddpbsd/ossec-hids
that referenced
this pull request
Aug 3, 2018
When writing rule id in json alerts file, the id is truncated and can be non unique, on intensive alerts generation. This is due snprintf buffer size which is too small to store id. Indeed id is composed of two long int (timestamp and log offset) then the size can be to 21 characters (10 digits for both timestamp and offset + the dot) The fix set id buffer to the correct size, and snprintf max size. wazuh/wazuh#1052 I'm not positive this affects us, but it probably doesn't hurt.
crolopez
approved these changes
Aug 30, 2018
vikman90
approved these changes
Sep 3, 2018
Member
|
Hi @gandalfn, Thank you very much for your contribution! Best regards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When writing rule id in json alerts file, the id is truncated and can be non unique, on intensive alerts generation.
This is due snprintf buffer size which is too small to store id. Indeed id is composed of two long int (timestamp and log offset) then the size can be to 21 characters (10 digits for both timestamp and offset + the dot)
The fix set id buffer to the correct size, and snprintf max size.