rate-limit routes calculation performed during topology broadcast updates#106
Closed
murali-reddy wants to merge 1 commit intoweaveworks:masterfrom
Closed
rate-limit routes calculation performed during topology broadcast updates#106murali-reddy wants to merge 1 commit intoweaveworks:masterfrom
murali-reddy wants to merge 1 commit intoweaveworks:masterfrom
Conversation
bboreham
approved these changes
Jun 4, 2019
Contributor
bboreham
left a comment
bboreham
left a comment
There was a problem hiding this comment.
I would like a comment on the "magic numbers" 2 and 4, and maybe a comment on the TODO, but can merge now and fix that later.
bboreham
reviewed
Jun 6, 2019
routes.go
Outdated
| type broadcastRoutes map[PeerName][]PeerName | ||
|
|
||
| var limiter = rate.NewLimiter(2, 4) | ||
| var pendingCalculate = false |
Contributor
There was a problem hiding this comment.
can these be members of routes rather than globals
Contributor
Author
|
Sorry, current fix seems to cause some regression. I did some scaling tests (>100 nodes). Connections seems to go into I need to investigate further. |
This was referenced Aug 22, 2019
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #105 rate-limit routes calculation done when a gossip topology update is received