Skip to content

fix: ignore listening for the directory itself to be deleted#251

Merged
alexander-akait merged 1 commit intomainfrom
feat/node22
May 16, 2025
Merged

fix: ignore listening for the directory itself to be deleted#251
alexander-akait merged 1 commit intomainfrom
feat/node22

Conversation

@xiaoxiaojx
Copy link
Member

After Node.js v22, fs.watch(dir) and deleting a dir will trigger the rename change event.
Here we just ignore it and keep the same behavior as before v22
libuv/libuv#4376

@xiaoxiaojx xiaoxiaojx force-pushed the feat/node22 branch 8 times, most recently from d9aae01 to 62c55d4 Compare May 14, 2025 13:22
@codecov
Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.73%. Comparing base (215eafd) to head (5f9ebb9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #251      +/-   ##
==========================================
+ Coverage   91.70%   91.73%   +0.03%     
==========================================
  Files           6        6              
  Lines        1049     1065      +16     
  Branches      253      258       +5     
==========================================
+ Hits          962      977      +15     
- Misses         87       88       +1     
Flag Coverage Δ
integration 91.73% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xiaoxiaojx xiaoxiaojx force-pushed the feat/node22 branch 9 times, most recently from 5ff1401 to 1a0917f Compare May 16, 2025 15:21
@alexander-akait alexander-akait merged commit 919c666 into main May 16, 2025
40 checks passed
@alexander-akait alexander-akait deleted the feat/node22 branch May 16, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants