Skip to content

fix: rename sourcemap flag to devtool#1723

Merged
alexander-akait merged 3 commits intowebpack:nextfrom
anshumanv:devtool
Aug 1, 2020
Merged

fix: rename sourcemap flag to devtool#1723
alexander-akait merged 3 commits intowebpack:nextfrom
anshumanv:devtool

Conversation

@anshumanv
Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

fix/refactor

Did you add tests for your changes?
Yes

If relevant, did you update the documentation?
Yes

Summary

  • Sorucemap flag is misleading, rename it to devtool to align with the config option

Does this PR introduce a breaking change?
Yes

Other information

@anshumanv anshumanv requested a review from a team as a code owner August 1, 2020 12:59
name: 'sourcemap',
usage: '--sourcemap <sourcemap | eval>',
name: 'devtool',
usage: '--devtool <source-map | eval>',
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need fix it, because we have more values here

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done @evilebottnawi 👍

@ghost

This comment has been minimized.

@alexander-akait alexander-akait merged commit 8623343 into webpack:next Aug 1, 2020
@anshumanv anshumanv deleted the devtool branch August 1, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants