fix: show warning if bail and watch are used together#1804
Merged
Conversation
snitin315
force-pushed
the
fix/bail-watch-warn
branch
from
29a3b95 to
a3e8ee8
Compare
snitin315
force-pushed
the
fix/bail-watch-warn
branch
from
ffd35ce to
6021ee3
Compare
snitin315
force-pushed
the
fix/bail-watch-warn
branch
from
1f54e89 to
52b7029
Compare
| expect(stderr).toContain(`You are using "bail" with "watch". "bail" will still exit webpack when the first error is found.`); | ||
| expect(stdout).toBeTruthy(); | ||
| }); | ||
| }); |
Member
There was a problem hiding this comment.
Can we add tests where bail: false and watch: true/watch: false and bail: true and check there is not warnings/errors?
snitin315
force-pushed
the
fix/bail-watch-warn
branch
from
52b7029 to
c43b93b
Compare
evenstensberg
previously approved these changes
Sep 20, 2020
rishabh3112
previously approved these changes
Sep 20, 2020
Member
rishabh3112
left a comment
rishabh3112
left a comment
There was a problem hiding this comment.
Left a small suggestion.
Rest looks good to me.
| @@ -0,0 +1,7 @@ | |||
| const logger = require('../logger'); | |||
|
|
|||
| module.exports = (compiler) => { | |||
Member
There was a problem hiding this comment.
Assign this to variable and then assign it to module.exports.
Add a comment about function(or file) as well.
snitin315
dismissed stale reviews from rishabh3112 and evenstensberg
via
685df00
evenstensberg
approved these changes
Sep 21, 2020
|
@jamesgeorge007 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @evenstensberg Please review the new changes. |
alexander-akait
approved these changes
Sep 21, 2020
jamesgeorge007
approved these changes
Sep 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
maybe fix
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
No
Summary
Fixes #1794
show a warning if
bailandwatchare used together with either config or as cli args.Does this PR introduce a breaking change?
No
Other information
No