fix: various tests are now working#1168
Merged
ematipico merged 2 commits intowebpack:nextfrom Jan 17, 2020
Merged
Conversation
- changed from `bundle.js` to `main.js` - applied merging strategy in the correct moment - fixed some tests
ematipico
force-pushed
the
bugfix/tests
branch
from
300562f to
bbe2213
Compare
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
rishabh3112
pushed a commit
to rishabh3112/webpack-cli
that referenced
this pull request
Jan 17, 2020
* fix: various tests are now working - changed from `bundle.js` to `main.js` - applied merging strategy in the correct moment - fixed some tests * fix: merge config test
ematipico
added a commit
that referenced
this pull request
Jan 20, 2020
* feat: add core-flags to help * chore: update line order * fix: ignore help flag * chore: converted ternary to arrow function * chore: immediate call arrow * chore: verbose variable names * feat: add usage to commands * chore: update syntax for export * tests: remove output flags from child process * tests: update multiarg help tests * test: replace init arg to create * tests: update string to be tested * chore: update tests * fix: various tests are now working (#1168) * fix: various tests are now working - changed from `bundle.js` to `main.js` - applied merging strategy in the correct moment - fixed some tests * fix: merge config test * chore: update cli-flags * chore: add comment and remove info * chore: update help * chore: update help * chore: fix code quality * chore: update snapshots Co-authored-by: Emanuele <my.burning@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bundle.jstomain.jsWhat kind of change does this PR introduce?
Bugfix of current tests
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Nope, not needed for now
Summary
Fixed current tests. They are all passing now. I had to turn off the promise one. It requires some more work.
Does this PR introduce a breaking change?
Nope
Other information