Merged
Conversation
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
ematipico
reviewed
Feb 24, 2020
ematipico
reviewed
Feb 24, 2020
snitin315
force-pushed
the
chore/improve-contributing.md
branch
from
b07b9f1 to
ea32ae3
Compare
Member
Author
|
@ematipico Updated 👍 |
ematipico
suggested changes
Feb 24, 2020
Contributor
ematipico
left a comment
ematipico
left a comment
There was a problem hiding this comment.
Thank you very much for this contribution! I would like to add a new section called "Testing the CLI locally". I can create an issue there and explain what's on my mind
snitin315
force-pushed
the
chore/improve-contributing.md
branch
from
ea32ae3 to
4b0e19c
Compare
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
|
@snitin315 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ematipico Please review the new changes. |
ematipico
approved these changes
Feb 24, 2020
mohitm15
approved these changes
Feb 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Made some enhancements in
CONTRIBUTING.md.Did you add tests for your changes?
NA
If relevant, did you update the documentation?
Yes
Summary
Does this PR introduce a breaking change?
No