fix(webpack-cli): handle promise rejection with package installation#1284
Merged
ematipico merged 3 commits intowebpack:nextfrom Mar 9, 2020
Merged
Conversation
jamesgeorge007
force-pushed
the
hotfix/handle-promise-rejection
branch
from
adeba96 to
ba059b1
Compare
ematipico
changed the title
ematipico
suggested changes
Mar 3, 2020
Contributor
ematipico
left a comment
ematipico
left a comment
There was a problem hiding this comment.
Could you create a test?
Member
Author
|
@ematipico it requires to mock the keyboard interrupts, and is gonna consume some sort of third party libraries for the purpose. |
Contributor
|
With jest you can mock libraries or modules. I believe it's doable |
jamesgeorge007
force-pushed
the
hotfix/handle-promise-rejection
branch
from
ffe7a6b to
a164a67
Compare
|
@jamesgeorge007 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ematipico Please review the new changes. |
jamesgeorge007
force-pushed
the
hotfix/handle-promise-rejection
branch
from
37f7873 to
dd914e0
Compare
jamesgeorge007
force-pushed
the
hotfix/handle-promise-rejection
branch
3 times, most recently
from
90fc912 to
fb1adbe
Compare
jamesgeorge007
force-pushed
the
hotfix/handle-promise-rejection
branch
from
fb1adbe to
d7f11a0
Compare
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
ematipico
previously approved these changes
Mar 7, 2020
snitin315
reviewed
Mar 7, 2020
jamesgeorge007
force-pushed
the
hotfix/handle-promise-rejection
branch
from
d7f11a0 to
8d479a8
Compare
snitin315
approved these changes
Mar 7, 2020
ematipico
approved these changes
Mar 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
Nope
If relevant, did you update the documentation?
N/A
Summary
closes #1283
Does this PR introduce a breaking change?
Nope
Other information
N/A