fix: defer setting default entry to core#1856
Merged
anshumanv merged 6 commits intowebpack:nextfrom Oct 3, 2020
Merged
Conversation
alexander-akait
previously approved these changes
Oct 3, 2020
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Big thanks!
/cc @webpack/cli-team
snitin315
previously approved these changes
Oct 3, 2020
Member
|
/cc @anshumanv can you fix conflicts? |
anshumanv
dismissed stale reviews from snitin315 and alexander-akait
via
0bd209d
Member
|
@anshumanv CI failed 😞 |
Member
Author
|
Ah minor issue, fixed 👍 |
Member
|
Feel free to merge after CI will be green ⭐ |
alexander-akait
approved these changes
Oct 3, 2020
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Feel free to merge after CI will be green
rishabh3112
approved these changes
Oct 3, 2020
gairTanm
reviewed
Oct 3, 2020
gairTanm
left a comment
gairTanm
left a comment
There was a problem hiding this comment.
Don't really understand all of it, but the default entry issue seems fixed 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
We're setting own default entry while core does this already so remove that logic.
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
LMK if there are places which need updates
Summary
Does this PR introduce a breaking change?
No
Other information
Fixes #1852