fix: remove unnecessary optional peer dependencies#1945
Merged
snitin315 merged 1 commit intowebpack:masterfrom Oct 14, 2020
Merged
fix: remove unnecessary optional peer dependencies#1945snitin315 merged 1 commit intowebpack:masterfrom
snitin315 merged 1 commit intowebpack:masterfrom
Conversation
Member
|
No, they are needed |
Contributor
Author
Member
|
|
alexander-akait
approved these changes
Oct 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix (this doesn't fix any bugs, but in terms of semver I think it should be a fix)
Did you add tests for your changes?
N/A
If relevant, did you update the documentation?
N/A
Summary
In #1816, default commands packages were added to peer dependencies of
@webpack-cli/package-utils, as they were required bypackageExistsin order to fix #1815.However, in #1822,
packageExistswas moved directly intowebpack-clinot@webpack-cli/utils, so@webpack-cli/utilsdoesn't require them.Does this PR introduce a breaking change?
No
Other information
Note #1815 has been fixed by #1822.