-
-
Notifications
You must be signed in to change notification settings - Fork 667
fix: handle undefined configuration export #2930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
eaf9f36
test: add test case for required behaviour
rishabh3112 2328313
chore: handle undefined configuration
rishabh3112 74896c8
test: add no code test case
rishabh3112 2f53013
chore: remove aggressive log
rishabh3112 397e6e5
chore: use suggestion
rishabh3112 3f25289
test: add test case for default undefined case
rishabh3112 da23efa
fix: invalid export case
rishabh3112 2442dc3
chore: update test descriptions
rishabh3112 424e0b7
chore: add newline
rishabh3112 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| "use strict"; | ||
| const { resolve } = require("path"); | ||
| const { run } = require("../../../utils/test-utils"); | ||
|
|
||
| describe("config flag with no code", () => { | ||
| it("should not throw error with no configuration or index file", async () => { | ||
| const { exitCode, stderr, stdout } = await run(__dirname, [ | ||
| "-c", | ||
| resolve(__dirname, "webpack.config.js"), | ||
| ]); | ||
|
|
||
| expect(exitCode).toBe(0); | ||
| expect(stderr).toBeFalsy(); | ||
| expect(stdout).toBeTruthy(); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| console.log("Peeves"); |
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| console.log("Tom Riddle"); |
16 changes: 16 additions & 0 deletions
16
test/build/config/undefined-default/undefined-default.test.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| "use strict"; | ||
| const { resolve } = require("path"); | ||
| const { run } = require("../../../utils/test-utils"); | ||
|
|
||
| describe("config flag with undefined default export config file", () => { | ||
| it("should not throw error with no configuration or index file", async () => { | ||
| const { exitCode, stderr, stdout } = await run(__dirname, [ | ||
| "-c", | ||
| resolve(__dirname, "webpack.config.js"), | ||
| ]); | ||
|
|
||
| expect(exitCode).toBe(0); | ||
| expect(stderr).toBeFalsy(); | ||
| expect(stdout).toBeTruthy(); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| module.exports.default = undefined; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| console.log("Percy Weasley"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| "use strict"; | ||
| const { resolve } = require("path"); | ||
| const { run } = require("../../../utils/test-utils"); | ||
|
|
||
| describe("config flag with undefined export config file", () => { | ||
| it("should not throw error with no configuration or index file", async () => { | ||
| const { exitCode, stderr, stdout } = await run(__dirname, [ | ||
| "-c", | ||
| resolve(__dirname, "webpack.config.js"), | ||
| ]); | ||
|
|
||
| expect(exitCode).toBe(0); | ||
| expect(stderr).toBeFalsy(); | ||
| expect(stdout).toBeTruthy(); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| module.exports = undefined; | ||
rishabh3112 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.