Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #2939 +/- ##
=======================================
Coverage 95.13% 95.13%
=======================================
Files 31 31
Lines 1684 1684
Branches 483 483
=======================================
Hits 1602 1602
Misses 82 82 Continue to review full report at Codecov.
|
alexander-akait
previously approved these changes
Sep 13, 2021
Member
Author
Still there are a lot of tests with bad descriptions 😞. If this is needs to be merged now, I can open a separate pull request later to address them. |
Member
|
You can continue work here 👍 |
alexander-akait
approved these changes
Sep 21, 2021
snitin315
approved these changes
Sep 21, 2021
anshumanv
pushed a commit
that referenced
this pull request
Oct 20, 2021
* fix: absent config test * chore: basic config description * chore: update default js config test * chore: update dot webpack config test * chore: update dot webpack webpackfile test * chore: fix description of cjs config * chore: update mjs config * chore: default config with mode * chore: fix empty test * chore: update empty array * chore: update empty function descriptions * chore: update empty promise * chore: update config array error * chore: update no config * chore: update invalid path file * chore: update config error test * chore: fix funtional config test * chore: invalid export * chore: update multiple config test * chore: update config test * chore: update no code test * chore: update no config array test * chore: update no config object test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
refactor
Did you add tests for your changes?
Yup
If relevant, did you update the documentation?
Not needed,
Summary
There are various grammatical mistakes as well as non standard descriptions.
Some cases also have redundant files.
Does this PR introduce a breaking change?
Nope
Other information
Discussed in #2930