refactor: migrate to node:test and setup jsdom environment#5667
Merged
Conversation
Member
|
Looks like test are failed... |
- Introduced a new script for node test setup (`scripts/node-test-setup.mjs`) to configure snapshot serializers and resolve snapshot paths for webpack tests. - Added new npm script `test:node` in `package.json` for running node tests with specific configurations. - Updated Jest snapshots in `proxy-option.test.js.snap.webpack5` to reflect changes in test descriptions. - Refactored tests in `open-option.test.js` and `proxy-option.test.js` to utilize `jest-mock` for mocking and spying, replacing previous Jest mocking methods. - Changed `beforeAll` and `afterAll` hooks to `before` and `after` for better test isolation and readability.
…tructure - Changed snapshot test descriptions to include a more structured format. - Updated snapshot assertions to use `t.assert.snapshot` for consistency. - Refactored test setup and teardown methods to use `before` and `after` from `node:test`. - Adjusted the test cases in `normalize-options.test.js` and `validate-options.test.js` for improved clarity and maintainability.
bjohansebas
force-pushed
the
migrate-jest-to-node-test-runner
branch
from
1f3bae9 to
3286583
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## next #5667 +/- ##
===========================================
+ Coverage 83.73% 94.59% +10.85%
===========================================
Files 11 135 +124
Lines 1943 32826 +30883
Branches 719 2 -717
===========================================
+ Hits 1627 31052 +29425
- Misses 283 1774 +1491
+ Partials 33 0 -33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Refactored multiple test files to utilize the `node:test` module for structuring tests. - Replaced direct assertions with `t.assert.snapshot` for snapshot testing. - Ensured consistency across tests by adding async context to test functions. - Updated imports to include necessary testing utilities from `node:test` and `expect`.
…assertions - Replaced traditional test structure with node:test for better test organization. - Updated snapshot assertions to use the new test framework's syntax. - Ensured all test cases in web-socket-communication.test.js, web-socket-server-url.test.js, and web-socket-server.test.js are consistent with the new structure.
…organization - Updated test files to utilize the `node:test` module for better compatibility and performance. - Replaced `jest.fn()` with `jest-mock` functions for mocking in various test cases. - Enhanced snapshot descriptions for clarity and consistency across tests. - Introduced a new `jsdom-setup.js` helper to streamline JSDOM configuration for tests. - Adjusted test cases to use `t.assert.snapshot()` for snapshot assertions. - Cleaned up mock implementations and reset logic in tests for improved reliability.
- Updated package.json to remove Jest dependencies and adjust test scripts for Node's test module. - Deleted globalSetupTest.js and setupTest.js as they are no longer needed. - Refactored ReactErrorBoundary.test.js to utilize real jsdom window/document. - Updated WebsocketClient.test.js to use async/await and improved test structure. - Skipped index.test.js due to dependency on Jest's mocking capabilities. - Refactored socket-helper.test.js to create a mock WebSocketClient class. - Updated log.test.js to simplify logger tests and remove unnecessary mocks. - Enhanced jsdom-setup.js to replace jsdom's WebSocket with Node's ws library for better testing of WebSocket connections.
…st test helper import
bjohansebas
commented
May 10, 2026
Member
Author
bjohansebas
left a comment
bjohansebas
left a comment
There was a problem hiding this comment.
Okay, once CI passes, I’m going to merge it. There really aren’t any major changes, and I made it so the snapshots wouldn’t change too much, although some of them did. But those are changes I verified myself. Jest components are still being used, but everything works normally. Otherwise, this PR would become even bigger, and I need this to unblock the http-proxy-middleware update, since Jest was a factor preventing us from updating it.
Member
Author
There was a problem hiding this comment.
t may look weird to run the test runner like that, but with so many flags there was a point where the fixtures were getting executed too, so I had to filter them out. And when using test-shard, it wouldn’t recognize them because of a Node.js bug, so this was the workaround.
| process.env.CHOKIDAR_USEPOLLING = "true"; | ||
|
|
||
| // Normalize "\r\n" and "\r" to "\n" so snapshots are platform-agnostic. | ||
| snapshot.setDefaultSnapshotSerializers([ |
Member
Author
There was a problem hiding this comment.
So the snapshots can keep working very similarly to how they worked with Jest, since there isn’t enough time to migrate to the Node.js format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What kind of change does this PR introduce?
Did you add tests for your changes?
Does this PR introduce a breaking change?
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Use of AI