Add register event && Add friendship && Add FileBox#20
Merged
huan merged 10 commits intowechaty:masterfrom Apr 13, 2020
dchaofei:master
Merged
Add register event && Add friendship && Add FileBox#20huan merged 10 commits intowechaty:masterfrom dchaofei:master
huan merged 10 commits intowechaty:masterfrom
dchaofei:master
Conversation
dchaofei
requested review from
a team,
SilkageNet,
dingdayu and
huan
and removed request for
a team
dingdayu
reviewed
Apr 9, 2020
dchaofei
changed the title
SilkageNet
approved these changes
Apr 9, 2020
dingdayu
approved these changes
Apr 9, 2020
Member
|
Great to see all of us approved this PR to be merged! I'd like to suggest that:
Thank you very much, I hope you all have a great weekend! |
Collaborator
Author
|
Can this pr be merged |
Member
|
@dchaofei Of course, please feel free to help yourself to merge this pull request because we have already two approvements on it! |
Collaborator
Author
|
I don't have merge permission. 😊 |
Member
|
Perhaps GitHub does not permit the PR author to merge the PR by himself? Ok, I'll merge this for you, and we can ask other contributors who have the write permission to help to merge in the future! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add register event.
Add friendship.
Add FileBox.
In order to solve the circular reference, I newly added the impl directory as the implementation of the interface, and write the interface to the wechaty directory. This should not be the best solution, but it can solve the current problem.