Skip to content

Migrate to GitHub Actions#133

Merged
vearutop merged 1 commit intomasterfrom
github-actions
Jan 24, 2023
Merged

Migrate to GitHub Actions#133
vearutop merged 1 commit intomasterfrom
github-actions

Conversation

@vearutop
Copy link
Copy Markdown
Contributor

@vearutop vearutop commented Jan 20, 2023 •
edited
Loading

Travis CI seem to be no longer working for free for public repositories, so migrating to GitHub Actions can improve CI.

This PR

  • migrates from Travis CI to GitHub Actions for better CI integration,
  • adds github.com/alicebob/miniredis to reduce test dependency on actual Redis (env REDIS_ADDR still allows actual Redis),
  • adds LOC, benchmark and API changes reports to pull requests,
  • updates go.mod with go1.17 to optimize transitive dependencies handling.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 20, 2023 •
edited
Loading

Lines Of Code

Language Files Lines Code Comments Blanks Complexity Bytes
Go (test) 6 1334 (+80) 1077 (+55) 41 216 (+25) 81 (+22) 38.3K (+1.2K)
Markdown 1 606 449 0 157 0 22.7K (+44B)
YAML 4 (+3) 364 (+348) 310 (+297) 16 (+16) 38 (+35) 0 13.3K (+13.1K)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 20, 2023 •
edited
Loading

Unit Test Coverage

total: (statements) 69.3%

Coverage of changed lines

No changes in testable statements.

Coverage diff with base branch

Missing base coverage file.

@vearutop vearutop changed the title Add GitHub Actions Migrate to GitHub Actions Jan 20, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 20, 2023

Go API Changes

# summary
Inferred base version: v5.0.1
Suggested version: v5.1.0

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 20, 2023 •
edited
Loading

Benchmark Result

Benchmark diff with base branch
Benchmark result 
name     time/op
Queue-2   180µs ± 2%

name     alloc/op
Queue-2  44.1kB ± 6%

name     allocs/op
Queue-2    87.7 ± 1%

@vearutop vearutop force-pushed the github-actions branch 2 times, most recently from 59cb6a0 to 1d89bd1 Compare January 21, 2023 15:21
@vearutop vearutop marked this pull request as ready for review January 21, 2023 15:23
@vearutop vearutop requested review from psampaz and wellle January 21, 2023 15:23
psampaz
psampaz approved these changes Jan 24, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@psampaz psampaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

mariaefi29
mariaefi29 approved these changes Jan 24, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@mariaefi29 mariaefi29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

Just some small suggestion to fix if you want :)

cleaner_test.go
"github.com/stretchr/testify/require"
)

func testRedis(t testing.TB) (addr string, closer func()) {
Copy link
Copy Markdown
Contributor

@mariaefi29 mariaefi29 Jan 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think if we put that func at the bottom of the test file?

Copy link
Copy Markdown
Contributor Author

@vearutop vearutop Jan 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the rationale for such layout?

Copy link
Copy Markdown
Contributor Author

@vearutop vearutop Jan 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this PR and let's change this later if there are benefits.

Copy link
Copy Markdown
Contributor

@mariaefi29 mariaefi29 Jan 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the rationale for such layout?

Unexported helpers functions are usually put at the end of file, since they are just helpers and not the main purpose of the file.

There is a layout approach I really like, I think I will share with the team later in Q1 to discuss.

@vearutop vearutop merged commit 180d9e8 into master Jan 24, 2023
@vearutop vearutop deleted the github-actions branch January 24, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wellle wellle Awaiting requested review from wellle

2 more reviewers

@mariaefi29 mariaefi29 mariaefi29 approved these changes

@psampaz psampaz psampaz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vearutop @psampaz @mariaefi29