Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical path alias collision issue that arose when the MobileClaw application was embedded within the 8claw environment. By standardizing MobileClaw's internal path alias from Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the project's import alias from @/ to @mc/. This change is reflected in tsconfig.json and vitest.config.ts configurations, and all relevant import statements across components, hooks, libraries, plugins, and test files have been updated to use the new @mc/ prefix. Additionally, a new test file, tests/parseBackendModels.test.ts, was added, adhering to the new alias convention.
MobileClaw is embedded inside 8claw which also uses @/ as its path alias. Turbopack can't do context-aware resolution, requiring a fragile per-file alias scanner in the parent config. Using a distinct @mc/ prefix eliminates the collision and lets both apps coexist with a single wildcard alias.
0ae6808 to
ea10ac6
Compare
Summary
@/path aliases to@mc/across 75 filestsconfig.jsonpaths andvitest.config.tsaliasWhy
MobileClaw is embedded inside 8claw, which also uses
@/as its tsconfig path alias. Turbopack can't do context-aware resolution, so the parent app needed a fragile file-scanning workaround (buildMobileclawAliases()) that required dev server restarts whenever files were added. Using a distinct@mc/prefix eliminates the collision — the parent config becomes a single@mc/*wildcard alias.Test plan
pnpm run build— passes, no type errorspnpm test— all 213 tests passpnpm devresolves@mc/correctlynext.config.mjs