Add detached mobile Safari document-scroll chat mode#47
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Sorry @wende, your pull request is larger than the review limit of 150000 diff characters
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the user experience for detached chat on mobile Safari by implementing a document-scroll mode. This change allows the chat interface to integrate more seamlessly with the browser's native scrolling behavior, improving responsiveness and visual consistency. Key aspects include refining the chat composer's layout, introducing a new scroll-to-bottom control, and optimizing service worker behavior for development environments. Additionally, the update expands the plugin system with new UI components for displaying various application-specific data. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
2be74c3 to
f3fe3ae
Compare
There was a problem hiding this comment.
Code Review
This pull request introduces a new document-scroll mode for detached mobile web chat, specifically targeting iOS Safari to improve its behavior. This involved significant refactoring of scroll management, layout calculations, and UI component rendering to adapt to the document's native scrolling. New plugin components for tour progress, connections, flow runs, and notifications have also been added, and tool call handling now supports narration. A bug was identified where the input bar's morphing animation is unconditionally disabled, affecting desktop, and an improvement was suggested for the isIpV4 regex to be more precise.
Summary
Testing
Follow-up