fix: include example WASM binaries in IPFS release tree#382
Merged
fix: include example WASM binaries in IPFS release tree#382
Conversation
The build-wasm job builds all examples (`make examples`) but the artifact upload only captured echo. The publish step also only placed std WASM files into the release tree, so examples loaded via IPNS (e.g. `ww run /ipns/<key>/examples/oracle`) fail with "No such file or directory" for bin/*.wasm. - Upload all examples/*/bin/ as wasm-artifacts - Copy example binaries into the IPFS release tree before publish
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build-wasmjob builds all examples (make examples) but the artifact upload only capturedexamples/echo/bin/echo.wasm, dropping oracle, counter, chess, etc.publish-ipfsjob only placed std WASM files into the release tree, so examples loaded via IPNS fail at runtime with missingbin/*.wasm.This fixes both: uploads all
examples/*/bin/as artifacts and copies them into the release tree beforeipfs add.Test plan
build-wasmartifact includes all example binariesexamples/oracle/bin/oracle.wasm,examples/counter/bin/counter.wasm, etc.ww run /ipns/<key>/examples/oracleloads without "No such file or directory"