[PEP - Wheel Variant] Staging before push to upstream by DEKHTIARJonathan · Pull Request #6 · wheelnext/peps

DEKHTIARJonathan · 2025-12-02T00:55:03Z

Rendered version: https://wheelnext.github.io/peps/pep-0815/

Done via: ``` m2r2 --no-underscore-emphasis pepxxx_wheel_variant_support.md ``` Signed-off-by: Michał Górny <mgorny@quansight.com>

Signed-off-by: Michał Górny <mgorny@quansight.com>

The pandoc's conversion is much better. Signed-off-by: Michał Górny <mgorny@quansight.com>

Signed-off-by: Michał Górny <mgorny@quansight.com>

peps/pep-0815.rst

Co-authored-by: Charlie Marsh <crmarsh416@gmail.com>

#6 (comment) Signed-off-by: Michał Górny <mgorny@quansight.com>

Signed-off-by: Michał Górny <mgorny@quansight.com>

DEKHTIARJonathan · 2025-12-08T18:30:12Z

I just added a beginning of "acknowledgements" section. I'll keep it updated.
Let me know if I forgot anyone

peps/pep-0815.rst

@rgommers

* Do a grammar run up to "Motivation" section Signed-off-by: Michał Górny <mgorny@quansight.com> * Extend "variant properties system" slightly Add an introduction on what they are, and mention that they are stored in the metadata. This makes the text easier to process when you are reading top-to-bottom, given that variant properties haven't been introduced yet. Signed-off-by: Michał Górny <mgorny@quansight.com> * Rewrite the null variant rationale Rewrite the rationale null variant for better readability and consistency. Remove redundant half-paragraph. Rewrite the sentences that sound like specification (specification already covers these bits). Signed-off-by: Michał Górny <mgorny@quansight.com> * Clarify the precedence between null variant and non-variant wheels Signed-off-by: Michał Górny <mgorny@quansight.com> * Updates up to "security implications" Signed-off-by: Michał Górny <mgorny@quansight.com> * First part of specification update Signed-off-by: Michał Górny <mgorny@quansight.com> * Final touches to the specification Signed-off-by: Michał Górny <mgorny@quansight.com> * Final sections, finally! Signed-off-by: Michał Górny <mgorny@quansight.com> * Apply suggestions from code review Co-authored-by: konsti <konstin@mailbox.org> * Apply more suggestions from Konsti Signed-off-by: Michał Górny <mgorny@quansight.com> * Restore "a choice" Signed-off-by: Michał Górny <mgorny@quansight.com> * Apply suggestion from @rgommers Co-authored-by: Ralf Gommers <ralf.gommers@gmail.com> * "could leads" → "leads" Signed-off-by: Michał Górny <mgorny@quansight.com> --------- Signed-off-by: Michał Górny <mgorny@quansight.com> Co-authored-by: konsti <konstin@mailbox.org> Co-authored-by: Ralf Gommers <ralf.gommers@gmail.com>

Signed-off-by: Michał Górny <mgorny@quansight.com>

* Add more links and cross-references Add links to projects we're talking about, when we're referencing them for the first time or haven't mentioned them in a while. Add more cross-references to make finding relevant bits easier, especially if we're talking about something that's specified later on. Cross-link to specifications more. Signed-off-by: Michał Górny <mgorny@quansight.com> * Undo OpenTeams link Signed-off-by: Michał Górny <mgorny@quansight.com> --------- Signed-off-by: Michał Górny <mgorny@quansight.com>

DEKHTIARJonathan · 2025-12-10T18:01:46Z

I can't approve my own PR - But thumbs up for me !

warsawnv · 2025-12-10T18:16:10Z

peps/pep-0815.rst

@@ -0,0 +1,2494 @@
+PEP: 815


Suggested change

PEP: 815

PEP: 817

I'll merge this once the PR is merged I need to rename a few files ;)

atalman

lgtm

warsawnv

This should be PEP 817 (the next available number as of this writing).

Also, you should add at least one (if not all) core devs in the authors list to .github/CODEOWNERS.

DEKHTIARJonathan · 2025-12-10T18:24:50Z

Also, you should add at least one (if not all) core devs in the authors list to .github/CODEOWNERS.
Ah good I didn't know, will do

seemethere

LGTM!

rgommers

LGTM too!

DEKHTIARJonathan · 2025-12-10T21:29:17Z

All authors have approved - I'll merge !

Congrats everybody !

mgorny and others added 23 commits November 27, 2025 18:58

PEP 815: Raw conversion from the "Wheel Variants" Markdown

1863fbc

Done via: ``` m2r2 --no-underscore-emphasis pepxxx_wheel_variant_support.md ``` Signed-off-by: Michał Górny <mgorny@quansight.com>

Add proper PEP headers

5e15f4e

Signed-off-by: Michał Górny <mgorny@quansight.com>

PEP 815: fix hyperlink conflicts

d4f4956

Signed-off-by: Michał Górny <mgorny@quansight.com>

Remove incorrect lexers

5c90b95

Signed-off-by: Michał Górny <mgorny@quansight.com>

Copy assets over

4a31e94

Signed-off-by: Michał Górny <mgorny@quansight.com>

Fix pre-commit issues

ce7849f

Signed-off-by: Michał Górny <mgorny@quansight.com>

Sync PEP 440 ref removal

8bfee58

Signed-off-by: Michał Górny <mgorny@quansight.com>

Update Konstantin's name

54a3131

Signed-off-by: Michał Górny <mgorny@quansight.com>

Fix pre-commit issues

cdcd189

Signed-off-by: Michał Górny <mgorny@quansight.com>

Update heading style per PEP 12

f113001

Signed-off-by: Michał Górny <mgorny@quansight.com>

Fix spacing around headings

1c7210b

Signed-off-by: Michał Górny <mgorny@quansight.com>

Restart with pandoc

6c7dc06

The pandoc's conversion is much better. Signed-off-by: Michał Górny <mgorny@quansight.com>

Fix headings again

f3d7d12

Signed-off-by: Michał Górny <mgorny@quansight.com>

Fix appendix references

1f176dd

Signed-off-by: Michał Górny <mgorny@quansight.com>

Fix code blocks

9bf098c

Signed-off-by: Michał Górny <mgorny@quansight.com>

Reindent code blocks & fix syntax hl

9f993d1

Signed-off-by: Michał Górny <mgorny@quansight.com>

Diversify list enumerators

3f25d19

Signed-off-by: Michał Górny <mgorny@quansight.com>

Use definition list for glossary

5a2934e

Signed-off-by: Michał Górny <mgorny@quansight.com>

Use enumerated lists when we say "three"

694cc9a

Signed-off-by: Michał Górny <mgorny@quansight.com>

Reflow

d27553f

Signed-off-by: Michał Górny <mgorny@quansight.com>

Provide alt text for images

943b36f

Signed-off-by: Michał Górny <mgorny@quansight.com>

Make use of cross-references

2e9a646

Signed-off-by: Michał Górny <mgorny@quansight.com>

WHLNXT render

fc43f22

charliermarsh reviewed Dec 2, 2025

View reviewed changes

mgorny and others added 2 commits December 2, 2025 11:13

Apply suggestions from code review

7bb0a66

Co-authored-by: Charlie Marsh <crmarsh416@gmail.com>

Apply suggestion from @charliermarsh

f43b252

Co-authored-by: Charlie Marsh <crmarsh416@gmail.com>

mgorny added a commit that referenced this pull request Dec 2, 2025

Include problems with depending on "package name" variants

1d07be6

#6 (comment) Signed-off-by: Michał Górny <mgorny@quansight.com>

mgorny added a commit that referenced this pull request Dec 2, 2025

Extend risks for fetching via sdist

52e9fbc

#6 (comment) Signed-off-by: Michał Górny <mgorny@quansight.com>

mgorny added 2 commits December 2, 2025 19:14

Include problems with depending on "package name" variants

f7cfa11

#6 (comment) Signed-off-by: Michał Górny <mgorny@quansight.com>

Extend risks for fetching via sdist

03f8924

#6 (comment) Signed-off-by: Michał Górny <mgorny@quansight.com>

mgorny and others added 2 commits December 8, 2025 18:51

Copy GROMACS chart desc from the paper

7eeadb0

Signed-off-by: Michał Górny <mgorny@quansight.com>

Some copy-edits to the text for clarity & project names

060b2eb

Acknowledgments Section

5eefc1f

DEKHTIARJonathan force-pushed the pep-wheel-variants-stage branch from 0a8a913 to 5eefc1f Compare December 8, 2025 18:51

dvrogozh reviewed Dec 9, 2025

View reviewed changes

peps/pep-0815.rst Outdated Show resolved Hide resolved

DEKHTIARJonathan added 3 commits December 9, 2025 18:04

Skip build if branch is norender*

c28c20d

Linter Fixes

a064f5b

Authors += "Andy R Terrel"

2631ecc

DEKHTIARJonathan force-pushed the pep-wheel-variants-stage branch from 470f088 to 2631ecc Compare December 9, 2025 23:12

JSON Schema Appendix

971ef1e

DEKHTIARJonathan force-pushed the pep-wheel-variants-stage branch from 1e6e4c1 to 971ef1e Compare December 10, 2025 00:38

konstin approved these changes Dec 10, 2025

View reviewed changes

mgorny and others added 3 commits December 10, 2025 11:47

Try a more smooth title (#27)

c9edd48

Signed-off-by: Michał Górny <mgorny@quansight.com>

mgorny approved these changes Dec 10, 2025

View reviewed changes

charliermarsh approved these changes Dec 10, 2025

View reviewed changes

msarahan approved these changes Dec 10, 2025

View reviewed changes

warsawnv reviewed Dec 10, 2025

View reviewed changes

atalman approved these changes Dec 10, 2025

View reviewed changes

warsawnv approved these changes Dec 10, 2025

View reviewed changes

aterrel approved these changes Dec 10, 2025

View reviewed changes

seemethere approved these changes Dec 10, 2025

View reviewed changes

dstufft approved these changes Dec 10, 2025

View reviewed changes

rgommers approved these changes Dec 10, 2025

View reviewed changes

DEKHTIARJonathan merged commit 4753493 into pep-wheel-variants-acceptance Dec 10, 2025
6 checks passed

Conversation

DEKHTIARJonathan commented Dec 2, 2025 • edited by mgorny Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DEKHTIARJonathan commented Dec 8, 2025

Uh oh!

Uh oh!

DEKHTIARJonathan commented Dec 10, 2025

Uh oh!

warsawnv Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

DEKHTIARJonathan Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

atalman left a comment

Choose a reason for hiding this comment

Uh oh!

warsawnv left a comment

Choose a reason for hiding this comment

Uh oh!

DEKHTIARJonathan commented Dec 10, 2025

Uh oh!

seemethere left a comment

Choose a reason for hiding this comment

Uh oh!

rgommers left a comment

Choose a reason for hiding this comment

Uh oh!

DEKHTIARJonathan commented Dec 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

DEKHTIARJonathan commented Dec 2, 2025 •

edited by mgorny

Loading