add mongoose 4-5 compatibility#16
Merged
wheresvic merged 1 commit intowheresvic:masterfrom Aug 23, 2018
Merged
Conversation
devdoomari3
force-pushed
the
add-mongoose-4-5-compatibility
branch
from
7810e30 to
7fbb504
Compare
devdoomari3
force-pushed
the
add-mongoose-4-5-compatibility
branch
from
edbd3a6 to
7484d84
Compare
Owner
|
Hi @devdoomari3 Thanks a lot for this PR, really appreciate it :) I have merged this in and published a new release v1.1.0, cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add mongoose 5 compatibility:
mongoose 5 does not have "next" function on hooks while mongoose 4 requires "next" function on hooks.
The solution is adding a 'fake' "next" function for mongoose5 for mongoose 4-5 compatibility.