Skip to content

Add support for "profiles" in user-specific directories.#9

Merged
whitequark merged 1 commit intowhitequark:masterfrom
SimonSapin:profiles
Dec 17, 2015
Merged

Add support for "profiles" in user-specific directories.#9
whitequark merged 1 commit intowhitequark:masterfrom
SimonSapin:profiles

Conversation

@SimonSapin
Copy link
Copy Markdown
Contributor

See doc-comment.

Bumping to 2.1 as it’s a new feature. (By the way, what does "pre" mean to you in version numbers?)

@whitequark
Copy link
Copy Markdown
Owner

You don't have to bump, because the currently published version is a pre-release. See paragraph 9 on http://semver.org/.

@whitequark
Copy link
Copy Markdown
Owner

Otherwise LGTM.

@SimonSapin
Copy link
Copy Markdown
Contributor Author

Amended. (Should Cargo handle pre-releases specially?)

@whitequark
Copy link
Copy Markdown
Owner

I worked under assumption that it does (i.e. * or ~> 2.0 do not include pre-releases; this is what e.g. Ruby's Bundler does). Is that not the case?

@SimonSapin
Copy link
Copy Markdown
Contributor Author

I don’t know. @alexcrichton, how does Cargo treat pre-release version numbers?

@alexcrichton
Copy link
Copy Markdown

Currently Cargo doesn't treat pre-release versions specially, the behavior just falls out of the standard logic for comparing semver versions

@whitequark
Copy link
Copy Markdown
Owner

@alexcrichton Actually, it does not. If I put xdg = "2.0" or xdg = ">= 2.0" in Cargo.toml, Cargo selects 2.0.0-pre5, which is in clear contradiction of the semver spec, paragraph 11

whitequark added a commit that referenced this pull request Dec 17, 2015
Add support for "profiles" in user-specific directories.
@whitequark whitequark merged commit 79e309a into whitequark:master Dec 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants