[ELYWEB-180] Elytron web consumes the InputStream when form parameters are parsed#213
Closed
rmartinc wants to merge 1 commit intowildfly-security:1.xfrom
Closed
[ELYWEB-180] Elytron web consumes the InputStream when form parameters are parsed#213rmartinc wants to merge 1 commit intowildfly-security:1.xfrom
rmartinc wants to merge 1 commit intowildfly-security:1.xfrom
Conversation
Author
|
Windows build is failing but in the previous sub-project |
Author
|
@fjuma I have rebased the PR now that the windows issue is fixed. Run the tests again please. |
Author
|
@fjuma What do you think about this? It was here for a long time... |
Contributor
|
Superceded by #297 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/ELYWEB-180
Wrapping the
HttpServletRequestto replay the request for the app. Main ideas:readStartedto true and avoiding each other).httpmimewas added to the pom (test scope) in order to test multi-part requests.@fjuma Please review this when you have time. The PR is a bit complicated but I reached the conclusion that wrapping is the only option here. If you see other solution just let me know.