[ELYEE-66] Rework the forking of Soteria code.#53
[ELYEE-66] Rework the forking of Soteria code.#53darranl merged 1 commit intowildfly-security:3.1.xfrom
Conversation
|
@jamezp Farah is not available to ACK - are you able to give a quick ACK so I can tag again, I have more tests passing locally now. |
jamezp
left a comment
jamezp
left a comment
There was a problem hiding this comment.
I don't have my laptop today as I'm on PTO, but I checked on my phone and it seemed okay. I assume this must just be some copy/paste changes which looks fine. It seems to be mostly format changes. There are some removal of final qualifiers that seems odd, but if it's just copy/paste changes that seems fine.
| } | ||
|
|
||
| private String getFullURL(HttpServletRequest request) { | ||
| private String getFullURL(HttpServletRequest request) { |
There was a problem hiding this comment.
This shouldn't block anything, but looks like just a white space change.
There was a problem hiding this comment.
thank you, I have resisted formatting updates this time other than as needed to get past checkstyle as it make it hard to compare this forked code with the original - Soteria has some bad formatting like this.
| import java.io.Serializable; | ||
| import java.security.Principal; | ||
|
|
||
| import javax.security.auth.callback.Callback; |
There was a problem hiding this comment.
This file seems like just format changes too.
|
Thank you, I am running a local all tests build to double check and will merge and tag in the morning. Apart from where I needed to tweak some imports this is a copy and paste from Soteria. Once we get to Soteria 4 for EE 11 we will not need the forked code as there is a mechanism there to add our integration directly. |
2 participants
https://issues.redhat.com/browse/ELYEE-66
Some additional classes needed to be imported, additionally classes that had been imported needed imports adjusting to use the other imported classes, finally Soteria formatting has been left in place to make it easier to compere with version 3.1.1.Final