[ELY-2892] Restore the original behaviour of RoleMapping login module…#2267
[ELY-2892] Restore the original behaviour of RoleMapping login module…#2267pedro-hos wants to merge 1 commit intowildfly-security:2.xfrom
Conversation
|
@pedro-hos As per our Elytron call, this PR is not ready for review. |
| @Message(id = 16005, value = "Path '%s' is a directory and cannot be used as a Role Mapper file.") | ||
| IllegalArgumentException propertiesRoleMapperPathIsDirectory(final String path); | ||
|
|
||
| @Message(id = 16006, value = "Cant read the provided properties file.") |
There was a problem hiding this comment.
| @Message(id = 16006, value = "Cant read the provided properties file.") | |
| @Message(id = 16006, value = "Can not read the provided properties file.") |
| @Message(id = 16006, value = "Cant read the provided properties file.") | ||
| IllegalStateException cantReadPropertiesFile(@Cause Throwable cause); | ||
|
|
||
| @Message(id = 16007, value = "Cant close the provided properties file.") |
There was a problem hiding this comment.
| @Message(id = 16007, value = "Cant close the provided properties file.") | |
| @Message(id = 16007, value = "Can not close the provided properties file.") |
|
|
||
| for(Map.Entry<String,String> entry: propertiesMap) { | ||
| if (rolesToMap.contains(entry.getKey())) { | ||
| for(String role: entry.getValue().split(",")) { |
There was a problem hiding this comment.
I understand that the file format is strict, however would it be useful/better UX to trim roles to avoid searching for invisible typos? For example for entries like "a=b,c " or "a=b, c".
pedro-hos
force-pushed
the
WFLY-20384-rolemapper
branch
from
2e70bd6 to
e5c42a0
Compare
|
Thank you for the review @OndrejKotek. I've just sent the PR with the changes. |
|
Hi @pedro-hos , since this is a new feature coming to WF ( https://issues.redhat.com/browse/WFLY-20384 ), this should target the 2.x branch |
|
Hi @skyllarr I've just changed the code base to 2.x. Thanks |
|
@pedro-hos Are you able to rebase and push to this PR so the CI runs again? It failed before and as it is expired, I can't re-run the failed tests manually. Thanks! |
… in the mapped role mapper https://issues.redhat.com/browse/ELY-2892
pedro-hos
force-pushed
the
WFLY-20384-rolemapper
branch
from
e5c42a0 to
0b9ea5c
Compare
4 participants
… in the mapped role mapper
https://issues.redhat.com/browse/ELY-2892