Skip to content

[ELY-2916] Fix NPE that occurs under heavy request load. #2289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VadimSharomov wants to merge 1 commit into
base: 1.19.x
Choose a base branch
from
Open

[ELY-2916] Fix NPE that occurs under heavy request load. #2289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions http/form/src/main/java/org/wildfly/security/http/form/FormAuthenticationMechanism.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ public String getMechanismName() {
@Override
public void evaluateRequest(final HttpServerRequest request) throws HttpAuthenticationException {
// Is current request an authentication attempt?
if (POST.equals(request.getRequestMethod()) && isAuthenticationRequest(request.getRequestURI().getPath())) {
if (POST.equals(request.getRequestMethod()) && request.getRequestURI() != null && isAuthenticationRequest(request.getRequestURI().getPath())) {
attemptAuthentication(request);
return;
}
Expand Down Expand Up @@ -327,7 +327,7 @@ private void sendLogin(HttpServerRequest request, HttpServerResponse response) t
// Save the current request.
URI requestURI = request.getRequestURI();
HttpScope session = getSessionScope(request, true);
if (session != null && session.supportsAttachments()) {
if (session != null && session.supportsAttachments() && requestURI != null) {
StringBuilder sb = new StringBuilder();
String scheme = requestURI.getScheme();
sb.append(scheme);
Expand Down