[ELY-2962] add JDK-25 to bld. Removed obsolete elements from workflow#2345
Conversation
.github/workflows/pr-ci.yaml
Outdated
| @@ -40,5 +52,20 @@ jobs: | |||
| restore-keys: ${{ runner.os }}-m2 | |||
There was a problem hiding this comment.
One small point, I think it is good to include the Java version in the restore key name as well
There was a problem hiding this comment.
@rsearls just a reminder that this small point was not addressed
rsearls
force-pushed
the
ELY-2962-JDK25-github-workflow-2.x
branch
from
873d981 to
9825477
Compare
|
Sorry @rsearls I think this conflicts now with your other PR I just merged - do we need both of your PRs for Java 24 and Java 25? Maybe these can be combined into one? |
|
We do want this change. It contains the performance improvement Ken recommended yesterday by slimplifying the host file rules. |
|
Hi @rsearls , I think you have to rebase this one now as it has conflicts |
rsearls
force-pushed
the
ELY-2962-JDK25-github-workflow-2.x
branch
from
9825477 to
486cecc
Compare
|
Rebase complete |
| - name: Check for file existence | ||
| id: file_check | ||
| run: | | ||
| if git ls-files --error-unmatch IsJdk24.txt > /dev/null 2>&1; then |
There was a problem hiding this comment.
Hi @rsearls , where should the file IsJdk24.txt be created?
There was a problem hiding this comment.
I understand now, it is in this PR https://github.com/wildfly-security/wildfly-elytron/pull/2344/files , so the jdk 25 build will be happening after that one is merged
There was a problem hiding this comment.
Now that the PR- 2344 has been merged. I'll rebase this one which will pickup the desired changes.
IsJdk24.txt is in the root directory of this PR.
There was a problem hiding this comment.
Opps sorry PR-2344 has NOT been merged yet. I'll wait for that and then rebase this one.
I will check that IsJdk24.txt is present I had to remove it in order to check that the first "if" check worked.
Perhaps I did not return it to the bld.
3 participants
https://issues.redhat.com/browse/ELY-2962