[ELY-2518] Move KeyStoreUtil to a new wildfly-elytron-keystore-util module#2393
Open
mskacelik wants to merge 1 commit intowildfly-security:2.xfrom
Open
[ELY-2518] Move KeyStoreUtil to a new wildfly-elytron-keystore-util module#2393mskacelik wants to merge 1 commit intowildfly-security:2.xfrom
mskacelik wants to merge 1 commit intowildfly-security:2.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @darranl @fjuma
issue: https://issues.redhat.com/browse/ELY-2518
Pretty much done what was asked for from the issue's description.
I have a few points I’d like to double-check regarding the current implementation:
1.) ElytronMessages & ID Conflict: Should I generate a unique message ID for this, or should I continue replicating
2035? The current approach causes a conflict inELY_Messages.txtdue to a module name mismatch.2.) util Module Structure & Parent POM: I’ve placed the new sub-module within
wildfly-elytron-keystore, but I kept its parent aswildfly-elytron-parent. Does it make more sense for it to inherit from thekeystoremodule instead?3.) Dependency Logic: I haven't added a dependency from
wildfly-elytron-keystoreto the newwildfly-elytron-keystore-util. Since the Util class isn't actually called within thekeystoremodule itself--including the deprecated sections--it seems this class is intended for end-user utility rather than internal API logic. Is that correct?