Skip to content

[ELY-2518] Move KeyStoreUtil to a new wildfly-elytron-keystore-util module#2393

Open
mskacelik wants to merge 1 commit intowildfly-security:2.xfrom
mskacelik:ELY-2518
Open

[ELY-2518] Move KeyStoreUtil to a new wildfly-elytron-keystore-util module#2393
mskacelik wants to merge 1 commit intowildfly-security:2.xfrom
mskacelik:ELY-2518

Conversation

@mskacelik
Copy link

@mskacelik mskacelik commented Feb 9, 2026

/cc @darranl @fjuma
issue: https://issues.redhat.com/browse/ELY-2518
Pretty much done what was asked for from the issue's description.

I have a few points I’d like to double-check regarding the current implementation:

1.) ElytronMessages & ID Conflict: Should I generate a unique message ID for this, or should I continue replicating 2035? The current approach causes a conflict in ELY_Messages.txt due to a module name mismatch.

2.) util Module Structure & Parent POM: I’ve placed the new sub-module within wildfly-elytron-keystore, but I kept its parent as wildfly-elytron-parent. Does it make more sense for it to inherit from the keystore module instead?

3.) Dependency Logic: I haven't added a dependency from wildfly-elytron-keystore to the new wildfly-elytron-keystore-util. Since the Util class isn't actually called within the keystore module itself--including the deprecated sections--it seems this class is intended for end-user utility rather than internal API logic. Is that correct?


$ mvn dependency:tree --file keystore/util/pom.xml
[INFO] --- dependency:3.8.1:tree (default-cli) @ wildfly-elytron-keystore-util ---
[INFO] org.wildfly.security:wildfly-elytron-keystore-util:jar:2.8.3.CR1-SNAPSHOT
[INFO] +- org.wildfly.security:wildfly-elytron-provider-util:jar:2.8.3.CR1-SNAPSHOT:compile
[INFO] +- org.wildfly.security:wildfly-elytron-x500-cert:jar:2.8.3.CR1-SNAPSHOT:compile
[INFO] |  \- org.wildfly.security:wildfly-elytron-x500-cert-util:jar:2.8.3.CR1-SNAPSHOT:compile
[INFO] +- org.wildfly.common:wildfly-common:jar:2.0.1:compile
[INFO] |  +- io.smallrye.common:smallrye-common-cpu:jar:2.4.0:compile
[INFO] |  +- io.smallrye.common:smallrye-common-expression:jar:2.4.0:compile
[INFO] |  |  \- io.smallrye.common:smallrye-common-function:jar:2.4.0:compile
[INFO] |  +- io.smallrye.common:smallrye-common-net:jar:2.4.0:compile
[INFO] |  |  \- io.smallrye.common:smallrye-common-constraint:jar:2.4.0:compile
[INFO] |  +- io.smallrye.common:smallrye-common-os:jar:2.4.0:compile
[INFO] |  \- io.smallrye.common:smallrye-common-ref:jar:2.4.0:compile
[INFO] +- org.jboss.logging:jboss-logging-annotations:jar:3.0.1.Final:provided
[INFO] +- org.jboss.logging:jboss-logging:jar:3.6.1.Final:provided
[INFO] +- org.wildfly.security:wildfly-elytron-base:jar:2.8.3.CR1-SNAPSHOT:test
[INFO] +- org.wildfly.security:wildfly-elytron-asn1:jar:2.8.3.CR1-SNAPSHOT:test
[INFO] +- org.wildfly.security:wildfly-elytron-x500:jar:2.8.3.CR1-SNAPSHOT:test
[INFO] +- commons-io:commons-io:jar:2.16.1:test
[INFO] +- org.bouncycastle:bcmail-jdk15on:jar:1.67:test
[INFO] |  +- org.bouncycastle:bcprov-jdk15on:jar:1.67:test
[INFO] |  \- org.bouncycastle:bcpkix-jdk15on:jar:1.67:test
[INFO] \- junit:junit:jar:4.13.1:test
[INFO]    \- org.hamcrest:hamcrest-core:jar:1.3:test

@mskacelik mskacelik requested a review from a team as a code owner February 9, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant