Conversation
Add CMAKE_CXX_STANDARD option because abseil requires c++17
Add CMAKE_CXX_STANDARD option because abseil requires c++17
Stop assuming it is only about GTK.
|
Hey @kathoum and @AlessandroBono - thanks so much for improving this. Since protobuf itself isn't the main focus of Gvsbuild, have you considered adding it to either the existing GTK3 or GTK4 runs rather than adding a completely separate CI run just for it? We can also change the zip filenames, but it also might be a breaking change for a project if they have some automation around downloading the latest release. |
|
We don't have preferences about having a separate build rather than adding protobuf to one of the existing runs. The goal is just to make sure that those packages don't break with an update. I think the difference is mainly for the users who download the release zip (would they prefer more packages in the archive, or rather smaller archives), and maybe for resource usage by github actions. Protobuf is small compared to gtk, so it makes sense to include it, but I'm also planning to add gstreamer (like in #1623) which will be quite large. For this reason @AlessandroBono went for an "Others" bundle, which is a reasonable choice. In both cases, I don't see a reason for changing the .zip names. |
Add "Protobuf" package set to the CI workflow.
Upgrade the packages:
Add patch to fix build error in protobuf-c in case there is a DLL in C:\ -- protobuf-c/protobuf-c#778