Make use of new safe-stable-stringify 2.x features #134
Merged
DABH merged 1 commit intowinstonjs:masterfrom Feb 12, 2022
Merged
Make use of new safe-stable-stringify 2.x features #134DABH merged 1 commit intowinstonjs:masterfrom
DABH merged 1 commit intowinstonjs:masterfrom
Conversation
mastermatt
force-pushed
the
upgrade-safe-stable-stringify
branch
from
bdb7743 to
c5df278
Compare
Contributor
|
@mastermatt I'm taking a look at this now. I just merged a dependabot PR that upgraded to 2.x so could you please rebase or fix merge conflicts here and I can look at the changes you have besides the version bump? Thanks! |
mastermatt
force-pushed
the
upgrade-safe-stable-stringify
branch
from
c5df278 to
f3a716c
Compare
mastermatt
changed the title
mastermatt
force-pushed
the
upgrade-safe-stable-stringify
branch
from
f3a716c to
6dd81e7
Compare
Contributor
Author
|
@DABH done. |
This commit originally included an upgrade of the lib itself from 1.x to 2.x. After a Dependabot PR was merged in to do the upgrade, this commit was rebased to only include the changes that take advantage of the new features. https://github.com/BridgeAR/safe-stable-stringify/releases ---- - Allow `opts` to configure the lib. - Update types for new opts. - Add tests to fill in coverage for json.js. NB. The `Buffer.toString('base64')` conversion was removed. Buffer implements `toJSON` so this block of code was not being executed anyway, as the replacer is called with the result of `toJSON`. Base64 was never being returned. https://nodejs.org/api/buffer.html#buftojson
mastermatt
force-pushed
the
upgrade-safe-stable-stringify
branch
from
6dd81e7 to
fef36ef
Compare
DABH
approved these changes
Feb 12, 2022
Contributor
DABH
left a comment
DABH
left a comment
There was a problem hiding this comment.
LGTM, thank you for adding tests!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/BridgeAR/safe-stable-stringify/releases
optsto configure the lib.NB. The
Buffer.toString('base64')conversion was removed. Buffer implementstoJSONso this block of code was not being executed anyway, as the replacer is called with the result oftoJSON. Base64 was never being returned.https://nodejs.org/api/buffer.html#buftojson