In CliFormat use cli levels (not npm levels).#135
Conversation
DABH
left a comment
There was a problem hiding this comment.
Could this be a breaking change? Can we union these two sets of levels so that there’s no chance of this being a break and change, and then fully do the switchover in the next major version? Or, is the proposed set of levels a strict superset of the current set of levels?
|
Hm, good question. The levels are https://github.com/winstonjs/triple-beam/blob/master/config/cli.js and https://github.com/winstonjs/triple-beam/blob/master/config/npm.js The only one that's in npm but not in cli is I'm not really sure if it could be a breaking change but I guess it's possible. |
|
I guess my intuition is that it's unlikely to be a breaking change unless someone is expecting a very specific format, down to the exact number of spaces, in their logs. But obviously it's your call. Happy to change it, or I checked the box so you can change it too. |
DABH
left a comment
There was a problem hiding this comment.
Let's go ahead and try this. Thank you!
This fixes winstonjs/winston#2053