fix: crash on attempt to uncolorize Symbol#188
Merged
wbt merged 1 commit intowinstonjs:masterfrom Jul 5, 2022
Merged
Conversation
Contributor
|
Thanks for the contribution! |
Contributor
|
Out in 2.4.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
.stripmethod of@colors/colors/safeis crashing when obtaining Symbol. According to its type definitions, non-strings are not supported. This PR would ensure that only string is provided.The provided test is crashing without the fix, just as expected.
Tested also with
winston- without the fix, usage ofuncolorizewith Symbol is crashing