Skip to content

fix: expose types dependency we depend on#243

Merged
wbt merged 1 commit intowinstonjs:masterfrom
carboneater:master
Feb 7, 2023
Merged

fix: expose types dependency we depend on#243
wbt merged 1 commit intowinstonjs:masterfrom
carboneater:master

Conversation

@carboneater
Copy link
Copy Markdown
Contributor

Simple solution to #242 : Mark the types we use as dependency.

simply running npm i @types/triple-beam in any of my failed projects fixes it.

@juicycool92
Copy link
Copy Markdown

juicycool92 commented Feb 7, 2023

Excuse me,

is this some kind of related my build failed symptoms that start from today?
i use winston@3.2.1 package in my node 18.13.0 server
and i keep failed due to below messages.

...

[Container] 2023/02/07 01:54:08 Running command npm run build

> MY_API@1.0.0 build
> tsc

node_modules/logform/index.d.ts(6,37): error TS7016: Could not find a declaration file for module 'triple-beam'. '/codebuild/output/src782303439/src/node_modules/triple-beam/index.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/triple-beam` if it exists or add a new declaration (.d.ts) file containing `declare module 'triple-beam';`
node_modules/logform/index.d.ts(11,3): error TS1169: A computed property name in an interface must refer to an expression whose type is a literal type or a 'unique symbol' type.
node_modules/logform/index.d.ts(12,3): error TS1169: A computed property name in an interface must refer to an expression whose type is a literal type or a 'unique symbol' type.
node_modules/logform/index.d.ts(13,3): error TS1169: A computed property name in an interface must refer to an expression whose type is a literal type or a 'unique symbol' type.

[Container] 2023/02/07 01:54:27 Command did not exit successfully npm run build exit status 2
[Container] 2023/02/07 01:54:27 Phase complete: BUILD State: FAILED
[Container] 2023/02/07 01:54:27 Phase context status code: COMMAND_EXECUTION_ERROR Message: Error while executing command: npm run build. Reason: exit status 2

Thanks

@benjdlambert
Copy link
Copy Markdown

@juicycool92 yes - this should fix #242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants